Change the default cell marker #7782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7782 +/- ##
==========================================
- Coverage 59.17% 59.16% -0.02%
==========================================
Files 498 498
Lines 22245 22254 +9
Branches 3573 3578 +5
==========================================
+ Hits 13164 13166 +2
- Misses 8259 8264 +5
- Partials 822 824 +2
Continue to review full report at Codecov.
|
DavidKutu
reviewed
Oct 5, 2019
| } | ||
|
|
||
| export namespace CodeSnippits { | ||
| export const ChangeDirectory = ['{0}', '{1}', 'import os', 'try:', '\tos.chdir(os.path.join(os.getcwd(), \'{2}\'))', '\tprint(os.getcwd())', 'except:', '\tpass', '']; | ||
| export const ChangeDirectoryCommentIdentifier = '# ms-python.python added'; // Not translated so can compare. | ||
| export const ImportIPython = '#%%\nfrom IPython import get_ipython\n\n'; | ||
| export const ImportIPython = '{0}\nfrom IPython import get_ipython\n\n{1}'; |
There was a problem hiding this comment.
Why is there a second parameter here?
There was a problem hiding this comment.
When this is used it's concatenated with another string.
In reply to: 331724874 [](ancestors = 331724874)
DonJayamanne
requested changes
Oct 7, 2019
package.nls.json
Outdated
| @@ -218,7 +218,7 @@ | |||
| "DataScience.exportingFormat": "Exporting {0}", | |||
| "DataScience.exportCancel": "Cancel", | |||
| "Common.canceled": "Canceled", | |||
| "DataScience.importChangeDirectoryComment": "#%% Change working directory from the workspace root to the ipynb file location. Turn this addition off with the DataScience.changeDirOnImportExport setting", | |||
| "DataScience.importChangeDirectoryComment": "# %% Change working directory from the workspace root to the ipynb file location. Turn this addition off with the DataScience.changeDirOnImportExport setting", | |||
There was a problem hiding this comment.
Shouldn't we remove this as well. I.e. if tomorrow a user wants the default to be #%%, it wont work everywhere as its hardcoded here.
I.e. use string.format as we've done in other places.
There was a problem hiding this comment.
package.nls.json
Outdated
| @@ -340,7 +340,7 @@ | |||
| "DataScience.jupyterDebuggerInstallPtvsdYes": "Yes", | |||
| "DataScience.jupyterDebuggerInstallPtvsdNo": "No", | |||
| "DataScience.cellStopOnErrorFormatMessage": "{0} cells were canceled due to an error in the previous cell.", | |||
| "DataScience.instructionComments": "# To add a new cell, type '#%%'\n# To add a new markdown cell, type '#%% [markdown]'\n", | |||
| "DataScience.instructionComments": "# To add a new cell, type '# %%'\n# To add a new markdown cell, type '# %% [markdown]'\n", | |||
There was a problem hiding this comment.
Same question as earlier, string.format to not hardcode # %%
Fix gather to use new comment Fix formatting on code comments from nls
rchiodo
added a commit
that referenced
this pull request
Oct 10, 2019
* Change the default cell marker * Fix test failures Fix gather to use new comment Fix formatting on code comments from nls * Fix unit test too * Fix gather to replace #%%
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7674